Viewer: enable pasting json report on app #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
requested changes
Dec 9, 2016
| const json = JSON.parse(e.clipboardData.getData('text')); | ||
| this.replaceReportHTML(json); | ||
| } catch (err) { | ||
| // noop |
There was a problem hiding this comment.
maybe log the failure here?
There was a problem hiding this comment.
Not sure it will be that useful to users. I'd prefer just ignoring random key pressing or users that accidentally paste something they didn't mean to in our app.
Note: replaceReportHTML will show a butter bar if the json file is invalid, so there's some feedback already built in if this go wrong.
| onPaste(e) { | ||
| e.preventDefault(); | ||
|
|
||
| ga('send', 'event', 'report', 'paste'); |
There was a problem hiding this comment.
should this be logging if it was an unsuccessful (e.g. inadvertent) paste?
|
PTAL |
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: all
So easy!